Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): remove notification double write feature flag #57863

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Oct 10, 2023

Now that we have double writes enabled for everyone, we can remove the feature flag entirely

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #57863 (4f47681) into master (de3a4e8) will increase coverage by 0.66%.
Report is 12 commits behind head on master.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master   #57863      +/-   ##
==========================================
+ Coverage   78.39%   79.06%   +0.66%     
==========================================
  Files        5135     5137       +2     
  Lines      223461   223577     +116     
  Branches    37624    37638      +14     
==========================================
+ Hits       175185   176760    +1575     
+ Misses      42629    41167    -1462     
- Partials     5647     5650       +3     
Files Coverage Δ
...dpoints/organization_events_root_cause_analysis.py 96.19% <100.00%> (+0.07%) ⬆️
...try/api/endpoints/user_notification_fine_tuning.py 100.00% <100.00%> (+1.16%) ⬆️
src/sentry/conf/server.py 89.83% <ø> (ø)
src/sentry/features/__init__.py 100.00% <ø> (ø)
src/sentry/notifications/helpers.py 91.07% <100.00%> (-0.49%) ⬇️
src/sentry/notifications/manager.py 85.41% <100.00%> (+0.86%) ⬆️
...sentry/services/hybrid_cloud/notifications/impl.py 76.85% <100.00%> (+0.70%) ⬆️
static/app/components/avatar/avatarList.tsx 90.90% <ø> (ø)
...c/sentry/integrations/slack/views/link_identity.py 86.36% <50.00%> (ø)
...ns/notifications/activity/new_processing_issues.py 89.79% <50.00%> (ø)
... and 1 more

... and 162 files with indirect coverage changes

@scefali scefali merged commit 268280e into master Oct 16, 2023
50 of 51 checks passed
@scefali scefali deleted the feat/remove-double-write-flag branch October 16, 2023 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants