fix(discord): Catch case where response from Discord takes a while #57522

17hogeju · 2023-10-04T21:49:13Z

tests/sentry/integrations/discord/test_utils.py

src/sentry/integrations/discord/utils/channel.py

fix(discord): Catch case where response from Discord takes a while

57f22ed

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 4, 2023

17hogeju commented Oct 4, 2023

View reviewed changes

tests/sentry/integrations/discord/test_utils.py Outdated Show resolved Hide resolved

Mock return value

4442156

vercel bot deployed to Preview October 4, 2023 22:43 View deployment

17hogeju marked this pull request as ready for review October 4, 2023 23:15

17hogeju requested a review from a team as a code owner October 4, 2023 23:15

17hogeju self-assigned this Oct 4, 2023

17hogeju added this to the Discord Integration milestone Oct 4, 2023

17hogeju requested review from scttcper and ceorourke and removed request for a team October 4, 2023 23:25

ceorourke reviewed Oct 4, 2023

View reviewed changes

src/sentry/integrations/discord/utils/channel.py Outdated Show resolved Hide resolved

Raise ApiTimeoutError instead of return false

adb6419

vercel bot deployed to Preview October 5, 2023 16:25 View deployment

17hogeju requested a review from ceorourke October 5, 2023 16:26

ceorourke reviewed Oct 5, 2023

View reviewed changes

src/sentry/integrations/discord/utils/channel.py Outdated Show resolved Hide resolved

ceorourke reviewed Oct 5, 2023

View reviewed changes

src/sentry/integrations/discord/utils/channel.py Outdated Show resolved Hide resolved

Julia Hoge added 2 commits October 5, 2023 11:04

Update channel.py

638e5cd

Update channel.py

1d858e0

17hogeju requested a review from ceorourke October 5, 2023 18:06

vercel bot deployed to Preview October 5, 2023 18:10 View deployment

ceorourke reviewed Oct 5, 2023

View reviewed changes

src/sentry/integrations/discord/utils/channel.py Outdated Show resolved Hide resolved

Update channel.py

950a2f6

17hogeju requested a review from ceorourke October 5, 2023 18:49

17hogeju enabled auto-merge (squash) October 5, 2023 18:49

vercel bot deployed to Preview October 5, 2023 18:53 View deployment

ceorourke approved these changes Oct 5, 2023

View reviewed changes

17hogeju merged commit 67bab6b into master Oct 5, 2023
49 checks passed

17hogeju deleted the julia/discord-timeout-fix branch October 5, 2023 19:19

github-actions bot locked and limited conversation to collaborators Oct 21, 2023

Provide feedback