fix(notifications): Fix parameters and add tests for participants and subscriptions #57053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
changed the title
scefali
reviewed
Oct 2, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scefali
reviewed
Oct 3, 2023
scefali
reviewed
Oct 3, 2023
scefali
reviewed
Oct 3, 2023
| @@ -584,7 +588,9 @@ def _get_subscriptions( | |||
| project_ids=project_ids, | |||
| type=NotificationSettingEnum.WORKFLOW, | |||
| ) | |||
| query_groups = {group for group in groups if (enabled_settings[group.project_id][1])} | |||
| query_groups = { | |||
| group for group in groups if (not enabled_settings[group.project_id][2]) | |||
There was a problem hiding this comment.
@snigdhas can we use something other than a tuple to make it more obvious what the 2nd parameter is?
There was a problem hiding this comment.
not really - the response from notification_service needs to be json serializable. We can re-map it to SubscriptionStatus like we do below, but it's not necessarily cleaner here.
There was a problem hiding this comment.
@snigdhas can we do a dictionary then instead of a tuple?
scefali
reviewed
Oct 3, 2023
scefali
reviewed
Oct 3, 2023
scefali
approved these changes
Oct 3, 2023
scefali
reviewed
Oct 3, 2023
| ) == {self.project.id: (False, True)} | ||
| ) == { | ||
| self.project.id: GroupSubscriptionStatus( | ||
| is_disabled=False, is_active=True, has_only_inactive_subscriptions=False |
There was a problem hiding this comment.
@snigdhas passing kwargs is so much better, thank you
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-1662
Fixes SENTRY-1663