feat(trace-view-load-more): Fixed bug that loads an extra row of orphans. #56561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ans past the limit.
github-actions
bot
added
the
Scope: Backend
narsaynorath
approved these changes
Sep 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #56561 +/- ##
==========================================
+ Coverage 77.50% 78.61% +1.11%
==========================================
Files 5078 5083 +5
Lines 218280 218997 +717
Branches 36952 37094 +142
==========================================
+ Hits 169173 172163 +2990
+ Misses 43423 41258 -2165
+ Partials 5684 5576 -108
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug allowing an extra row of orphan to be loaded past the row count limit in the trace view:
