fix(dashboards): Use loading indicator to avoid multiple requests #56558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the metrics compatibility check, if we don't use the loader then the children will attempt to render, triggering a bunch of requests to our dashboard endpoints. This causes the occurrence of 429s to increase. I'm re-enabling the loading state because this is a big issue and it doesn't look out of place when the dashboard is loading up either.
github-actions
bot
added
the
Scope: Frontend
narsaynorath
deleted the
nar/fix/dashboards-multiple-requests-due-to-hiding-metrics-loader
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboard widgets were doing 2x the requests when there should only be one. This causes the occurrence of 429s to increase when opening a dashboard and is a poor user experience. The issue was hiding the loading in the metrics compatibility check. If we don't use the loader then the children (i.e. the widgets) will attempt to render, triggering a bunch of requests to our dashboard endpoints, and when the check is complete then we'll re-render and re-fetch metrics enhanced data.
I'm re-enabling the loading state because this is a big issue and it doesn't look out of place when the dashboard is loading up either.