Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ui): Refine featureDisabled prop type #56538

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

scttcper
Copy link
Member

later int the file typescript compares Alert and React.ElementType and this was slow. We can refine the props we expect the component to have

before
image

after
image

later int the file typescript compares `Alert` and `React.ElementType` and this was slow. We can refine the props we expect the component to have
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 20, 2023
@scttcper scttcper marked this pull request as ready for review September 20, 2023 16:57
@scttcper scttcper requested a review from a team September 20, 2023 16:57
@scttcper scttcper merged commit 20f7842 into master Sep 20, 2023
42 checks passed
@scttcper scttcper deleted the scttcper/ts-feature-disabled branch September 20, 2023 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants