Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(starfish): add span domain array #56494

Merged
merged 4 commits into from
Sep 20, 2023
Merged

feat(starfish): add span domain array #56494

merged 4 commits into from
Sep 20, 2023

Conversation

wmak
Copy link
Member

@wmak wmak commented Sep 19, 2023

  • This adds a new field alias that will eventually replace span.domain it will split the domain string by , and return an array of span domains
  • This allows filtering on the span.domain field as if it was a real array

@wmak
feat(starfish): Add span domain array
10dd1f4 
- This adds a new field alias that will eventually replace `span.domain`
  it will split the domain string by `,` and return an array of span
  domains
- This allows filtering on the span.domain field as if it was a real
  array
@wmak
Merge branch 'master' into wmak/feat/add-span-domain-array
4f5cf3d
@wmak
fix: bad merge
4f6acff
@wmak wmak requested review from a team September 19, 2023 19:46
@wmak wmak requested a review from a team as a code owner September 19, 2023 19:46
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 19, 2023
@wmak wmak changed the title Wmak/feat/add span domain array feat(starfish): add span domain array Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #56494 (0ad02a1) into master (dc8c226) will decrease coverage by 0.03%.
Report is 12 commits behind head on master.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##           master   #56494      +/-   ##
==========================================
- Coverage   78.65%   78.63%   -0.03%     
==========================================
  Files        5078     5078              
  Lines      218278   218277       -1     
  Branches    36952    36947       -5     
==========================================
- Hits       171681   171634      -47     
- Misses      41054    41105      +51     
+ Partials     5543     5538       -5
Files Changed Coverage
src/sentry/search/events/datasets/spans_metrics.py 35.71%
src/sentry/search/events/constants.py 100.00%

@wmak wmak merged commit 64d5827 into master Sep 20, 2023
49 of 50 checks passed
@wmak wmak deleted the wmak/feat/add-span-domain-array branch September 20, 2023 16:47
@AbhiPrasad AbhiPrasad mentioned this pull request Sep 27, 2023
Merged
AbhiPrasad added a commit that referenced this pull request Sep 27, 2023
@AbhiPrasad
fix(starfish): Don't query for span.domain field for spans table (#57031
13f4454 
)

In #56494 we stopped using
`span.domain`, so let's stop querying for it to render the spans table.

Once #57028 merges in, we'll
revert all of these changes and go back to relying on `span.domain`.

Endpoint details page breaks, but we'll be fixing this right afterwards.
@AbhiPrasad AbhiPrasad mentioned this pull request Sep 27, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmak @AbhiPrasad