chore(github-growth): stop writing to commitfilechange language column #56491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
schew2381
approved these changes
Sep 19, 2023
|
@schew2381 i'm going to delete the column from edit: and add a column to |
cathteng
deleted the
cathy/github-growth/stop-writing-to-commitfilechange-language
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original premise for writing to the
CommitFileChangetable to store thelanguageassociated with a change made in a commit was so that we could see the languages being used by organizations.We could instead save the languages associated with commits in the
Repositorytable, so we wouldn't need to write toCommitFileChangerows -- we also aren't interested in the number of changes that are being made in a particular language, just that folks are working in some language. The CommitFileChange table is also massive (1 billion plus rows) and querying is very slow.This PR removes writes to the language column in the CommitFileChange model in preparation for removing the column. Undoes #55880