Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backup): Handle UserRole name collisions #56479

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix(backup): Handle UserRole name collisions #56479

merged 1 commit into from
Sep 19, 2023

Conversation

azaslavsky
Copy link
Contributor

@azaslavsky azaslavsky marked this pull request as ready for review September 19, 2023 15:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #56479 (d6cfadd) into master (d32bc6a) will increase coverage by 21.84%.
Report is 1 commits behind head on master.
The diff coverage is 57.14%.

❗ Current head d6cfadd differs from pull request most recent head 8b38c70. Consider uploading reports for the commit 8b38c70 to get more accurate results

@@             Coverage Diff             @@
##           master   #56479       +/-   ##
===========================================
+ Coverage   56.79%   78.64%   +21.84%     
===========================================
  Files        5063     5078       +15     
  Lines      217796   218269      +473     
  Branches    36879    36951       +72     
===========================================
+ Hits       123696   171656    +47960     
+ Misses      90024    41075    -48949     
- Partials     4076     5538     +1462
Files Changed Coverage
src/sentry/models/userrole.py 57.14%

@azaslavsky azaslavsky enabled auto-merge (squash) September 19, 2023 16:14
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/userrole_collisions branch 2 times, most recently from 463c73e to 659e56a Compare September 19, 2023 16:16
@azaslavsky azaslavsky force-pushed the azaslavsky/backup/userrole_collisions branch from 659e56a to 8b38c70 Compare September 19, 2023 16:17
@azaslavsky azaslavsky enabled auto-merge (squash) September 19, 2023 16:17
@azaslavsky azaslavsky merged commit 69cc8ff into master Sep 19, 2023
49 checks passed
@azaslavsky azaslavsky deleted the azaslavsky/backup/userrole_collisions branch September 19, 2023 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hubertdeng123 hubertdeng123 hubertdeng123 approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azaslavsky @hubertdeng123