fix(github-invite): improve performance of missing members API

[cathteng]

For orgs with many commit authors that are not members of their organization, the missing members API is timing out because there are too many commit authors to serialize (SENTRY-14QD).

We should limit the number of missing members to the 50 most active missing members. I also pulled out an inner join into its own query so it's more readable.

[codecov]

Codecov Report

Merging #56477 (d3ba954) into master (dc18d59) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #56477      +/-   ##
==========================================
- Coverage   78.64%   78.64%   -0.01%     
==========================================
  Files        5078     5078              
  Lines      218272   218260      -12     
  Branches    36952    36949       -3     
==========================================
- Hits       171670   171650      -20     
- Misses      41064    41070       +6     
- Partials     5538     5540       +2     

Files Changed	Coverage
.../api/endpoints/organization_missing_org_members.py	100.00%

[nhsiehgit]

👍

Does separating the query out really make it faster?
Maybe you can prefetch the fk'd table?

[evanpurkhiser]

Does separating the query out really make it faster?

I think the LIMIT 50 is what's making it faster here

[cathteng]

@evanpurkhiser @nhsiehgit i edited the description so nathan was right to ask. looking into prefetching now

[evanpurkhiser]

Oh, the query did actually change, the code wasn't just split out 👍

[evanpurkhiser]

Oh could you share the sentry performance metrics here as well?

[cathteng]

@evanpurkhiser i don't think there are performance metrics because the API call times out? this is the issue SENTRY-14QD

[evanpurkhiser]

It doesn't always though right? I think there should be a transaction for this endpoint right?

[cathteng]

@evanpurkhiser failure rate 19% here

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ OperationalError: QueryCanceled('canceling statement due to user request\n') /api/0/organizations/{organization_slug}/missin... View Issue

_{Did you find this useful? React with a 👍 or 👎}