Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hybrid-cloud): Mark extract_user_ids_from_mentions to be a region silo function #56441

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

dashed
Copy link
Member

@dashed dashed commented Sep 18, 2023

extract_user_ids_from_mentions() is only used in region silo endpoints. So I've updated the associated tests to be region silo stable.

@dashed dashed requested a review from a team September 18, 2023 23:56
@dashed dashed self-assigned this Sep 18, 2023
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #56441 (7cfc75b) into master (ff6e314) will decrease coverage by 0.02%.
Report is 33 commits behind head on master.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master   #56441      +/-   ##
==========================================
- Coverage   78.65%   78.63%   -0.02%     
==========================================
  Files        5076     5078       +2     
  Lines      218180   218363     +183     
  Branches    36929    36962      +33     
==========================================
+ Hits       171600   171719     +119     
- Misses      41038    41103      +65     
+ Partials     5542     5541       -1     
Files Changed Coverage
.../sentry/api/endpoints/organization_events_trace.py 27.27%
.../sentry/api/serializers/rest_framework/mentions.py 100.00%

@dashed dashed merged commit d2b3880 into master Sep 20, 2023
50 of 51 checks passed
@dashed dashed deleted the hybrid-cloud/split-silo-test/test-mentions branch September 20, 2023 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants