Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jira-server): try a second project for jira server if the first one fails #56439

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Sep 18, 2023

When Sentry loads the initial config for Jira Server, we pick the first project we find if there isn't one set. Sometimes that project is in a bad state. So if the first request fails, we try the second project and use that instead.

@scefali scefali requested a review from a team as a code owner September 18, 2023 23:30
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 18, 2023
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a shot, this bug is so weird.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #56439 (bf37c4b) into master (9c83e9f) will increase coverage by 0.00%.
Report is 14 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #56439   +/-   ##
=======================================
  Coverage   78.62%   78.63%           
=======================================
  Files        5077     5078    +1     
  Lines      218303   218356   +53     
  Branches    36950    36962   +12     
=======================================
+ Hits       171649   171700   +51     
  Misses      41108    41108           
- Partials     5546     5548    +2     
Files Changed Coverage
src/sentry/integrations/jira_server/integration.py 100.00%

@scefali scefali merged commit ca1be44 into master Sep 19, 2023
50 of 51 checks passed
@scefali scefali deleted the fix/jira-server-try-second-project branch September 19, 2023 16:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants