Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Add alert.sent analytics for issue alerts #56151

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Sep 13, 2023

this is somewhat duplicate of notification_sent but allows for easier selection of all alerts and their CTR

fixes #54423
fixes #54419

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #56151 (82f346b) into master (2db32ef) will increase coverage by 0.01%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #56151      +/-   ##
==========================================
+ Coverage   79.98%   80.00%   +0.01%     
==========================================
  Files        5062     5062              
  Lines      217704   217715      +11     
  Branches    36855    36854       -1     
==========================================
+ Hits       174128   174172      +44     
+ Misses      38230    38199      -31     
+ Partials     5346     5344       -2     
Files Changed Coverage
src/sentry/notifications/notifications/digest.py 100.00%
src/sentry/notifications/notifications/rules.py 100.00%

@scttcper scttcper marked this pull request as ready for review September 13, 2023 16:40
@scttcper scttcper requested a review from a team as a code owner September 13, 2023 16:40
@scttcper scttcper merged commit 059501d into master Sep 13, 2023
55 checks passed
@scttcper scttcper deleted the scttcper/alert-sent-issue-alerts branch September 13, 2023 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Alert Analytic for Digests Add Issue Alerts Analytic after Message Sent for each Provider
2 participants