-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts): Add notification_uuid to incident actions #54891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the notification_uuid to various incident actions. Only starts using it in slack. Will follow up with the others.
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Aug 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54891 +/- ##
==========================================
- Coverage 79.98% 79.98% -0.01%
==========================================
Files 5037 5037
Lines 214727 214800 +73
Branches 36477 36490 +13
==========================================
+ Hits 171753 171811 +58
- Misses 37695 37713 +18
+ Partials 5279 5276 -3
|
jangjodi
reviewed
Aug 28, 2023
@@ -101,6 +101,7 @@ def send_incident_alert_notification( | |||
incident: Incident, | |||
metric_value: int | None, | |||
new_status: IncidentStatus, | |||
notification_uuid: str | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be passing notification_uuid
to build_incident_attachment
here?
jangjodi
approved these changes
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a notification_uuid to various incident actions. Passes it down to the message builder which will make its way into slack, pagerduty, others
Not yet emitting an analytic event when we send the message.
part of #54417