Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Add notification_uuid to incident actions #54891

Merged
merged 13 commits into from
Aug 29, 2023

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Aug 16, 2023

Adds a notification_uuid to various incident actions. Passes it down to the message builder which will make its way into slack, pagerduty, others

Not yet emitting an analytic event when we send the message.

part of #54417

Adds the notification_uuid to various incident actions. Only starts using it in slack. Will follow up with the others.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #54891 (08a4d12) into master (95f56de) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 95.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54891      +/-   ##
==========================================
- Coverage   79.98%   79.98%   -0.01%     
==========================================
  Files        5037     5037              
  Lines      214727   214800      +73     
  Branches    36477    36490      +13     
==========================================
+ Hits       171753   171811      +58     
- Misses      37695    37713      +18     
+ Partials     5279     5276       -3     
Files Changed Coverage Δ
...c/sentry/integrations/slack/utils/notifications.py 83.33% <ø> (ø)
...c/sentry/services/hybrid_cloud/integration/impl.py 81.18% <ø> (ø)
...entry/services/hybrid_cloud/integration/service.py 80.20% <ø> (ø)
static/app/components/pluginConfig.tsx 64.86% <ø> (+2.00%) ⬆️
static/app/utils/useHotkeys.tsx 100.00% <ø> (ø)
...views/settings/project/projectKeys/list/keyRow.tsx 100.00% <ø> (ø)
...ectDebugFiles/sources/customRepositories/index.tsx 58.57% <ø> (ø)
src/sentry/incidents/tasks.py 83.62% <50.00%> (-1.21%) ⬇️
src/sentry/incidents/action_handlers.py 89.18% <100.00%> (+0.22%) ⬆️
src/sentry/incidents/logic.py 91.54% <100.00%> (+0.01%) ⬆️
... and 8 more

... and 40 files with indirect coverage changes

@@ -101,6 +101,7 @@ def send_incident_alert_notification(
incident: Incident,
metric_value: int | None,
new_status: IncidentStatus,
notification_uuid: str | None = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be passing notification_uuid to build_incident_attachment here?

@scttcper scttcper requested a review from jangjodi August 28, 2023 23:00
@scttcper scttcper merged commit d94c79d into master Aug 29, 2023
59 checks passed
@scttcper scttcper deleted the scttcper/incident-add-uuid branch August 29, 2023 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants