feat(alerts): Add notification_uuid column to incident activity #54809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incident activities map 1:1 to a status change in an incident resolved/warning/critical. This is similar to RuleFireHistory in issue alerts. A notification is sent when a new incident activity is created
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Add field notification_uuid to incidentactivity
--
ALTER TABLE "sentry_incidentactivity" ADD COLUMN "notification_uuid" uuid NULL; |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54809 +/- ##
==========================================
+ Coverage 79.80% 79.83% +0.03%
==========================================
Files 5002 5019 +17
Lines 212481 213403 +922
Branches 36202 36325 +123
==========================================
+ Hits 169563 170380 +817
- Misses 37698 37785 +87
- Partials 5220 5238 +18
|
markstory
approved these changes
Aug 16, 2023
jangjodi
reviewed
Aug 16, 2023
scttcper
changed the title
scttcper
changed the title
wedamija
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incident activities map 1:1 to a status change in an incident - eg. resolved/warning/critical. This is similar to RuleFireHistory in issue alerts. A notification is sent when a new incident activity is created
We'll use this uuid to track the number of people notified from each status change and later the CTR