Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: upgrade datadog to a typed version #54758

Merged
merged 1 commit into from
Aug 15, 2023
Merged

ref: upgrade datadog to a typed version #54758

merged 1 commit into from
Aug 15, 2023

Conversation

asottile-sentry
Copy link
Member

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #54758 (e49a254) into master (60f2390) will increase coverage by 0.00%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #54758   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files        5000     5000           
  Lines      212316   212317    +1     
  Branches    36178    36178           
=======================================
+ Hits       169399   169400    +1     
+ Misses      37705    37704    -1     
- Partials     5212     5213    +1
Files Changed Coverage Δ
src/sentry/metrics/datadog.py 73.46% <100.00%> (+0.55%) ⬆️

... and 6 files with indirect coverage changes

@asottile-sentry asottile-sentry marked this pull request as ready for review August 15, 2023 16:01
@asottile-sentry asottile-sentry requested a review from a team as a code owner August 15, 2023 16:01
@asottile-sentry asottile-sentry requested review from a team August 15, 2023 16:01
@asottile-sentry asottile-sentry merged commit 3bfe952 into master Aug 15, 2023
61 checks passed
@asottile-sentry asottile-sentry deleted the asottile-upgrade-datadog branch August 15, 2023 18:06
@beezz beezz added the Trigger: Revert add to a merged PR to revert it (skips CI) label Aug 15, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: 7e46c18

getsentry-bot added a commit that referenced this pull request Aug 15, 2023
@getsentry-bot @beezz
Revert "ref: upgrade datadog to a typed version (#54758)"
7e46c18 
This reverts commit 3bfe952.

Co-authored-by: beezz <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanWoodard IanWoodard IanWoodard approved these changes

@JoshFerge JoshFerge JoshFerge approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asottile-sentry @getsentry-bot @JoshFerge @IanWoodard @beezz