fix(metrics-layer): Add xfailing metrics layer sort test #54712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Aug 14, 2023
wmak
commented
- This adds a test that's failing where sort order isn't being maintained consistently in the metrics layer
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54712 +/- ##
=======================================
Coverage 79.78% 79.78%
=======================================
Files 5000 4999 -1
Lines 212357 212333 -24
Branches 36198 36196 -2
=======================================
- Hits 169426 169409 -17
+ Misses 37714 37709 -5
+ Partials 5217 5215 -2 |
shruthilayaj
approved these changes
Aug 15, 2023
- This adds a test that's failing where sort order isn't being maintained consistently in the metrics layer
wmak
force-pushed
the
wmak/fix/add-xfailing-metric-layer-sort-test
branch
from
10171a1
to
bf1ba56
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.