feat(integrations): create redis keys using integration_id #54655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54655 +/- ##
=======================================
Coverage 79.76% 79.76%
=======================================
Files 5001 5000 -1
Lines 212325 212296 -29
Branches 36184 36176 -8
=======================================
- Hits 169352 169341 -11
+ Misses 37767 37748 -19
- Partials 5206 5207 +1
|
ceorourke
reviewed
Aug 14, 2023
| @@ -40,7 +40,8 @@ class BitbucketServerSetupClient(ApiClient): | |||
| authorize_url = "{}/plugins/servlet/oauth/authorize?oauth_token={}" | |||
| integration_name = "bitbucket_server_setup" | |||
|
|
|||
| def __init__(self, base_url, consumer_key, private_key, verify_ssl=True): | |||
| def __init__(self, base_url, consumer_key, private_key, verify_ssl=True, *args, **kwargs): | |||
| super().__init__(*args, **kwargs) | |||
There was a problem hiding this comment.
I don't know that this will help for bitbucket server - I don't see this initialized with an integration id and the parent class doesn't have it either.
ceorourke
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding integration id's to integration clients to be used to create redis keys for the
IntegrationRequestBufferused to detect and disable integrations for the Notify on Disabled Integration project