ref(crons): Use redis GETSET over a lock for synchronization #54341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-use-redis-getset-over-a-lock-for-synchronization
branch
from
dda7344
to
b135552
Compare
rjo100
reviewed
Aug 7, 2023
|
|
||
| # If more than exactly a minute has passed then we've skipped a | ||
| # task run, report that to sentry, it is a problem. | ||
| if last_ts is not None and last_ts + 60 != reference_ts: |
There was a problem hiding this comment.
if last_ts is None do we want to process? or wait for a full minute for it to clear out/increment?
feel like we should process in the case of deployments etc
There was a problem hiding this comment.
I think it's OK to process it yeah.
There was a problem hiding this comment.
We do already, this is just guarding the exception logic for when it skips
There was a problem hiding this comment.
oh right i was reading this backwards
Instead of taking a lock when ticking the monitor tasks trigger clock, we can use redis' `GETSET` command to retrieve the current value and set a new value atomically.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54341 +/- ##
==========================================
- Coverage 79.66% 79.66% -0.01%
==========================================
Files 4985 4985
Lines 211352 211346 -6
Branches 36026 36026
==========================================
- Hits 168373 168365 -8
- Misses 37800 37804 +4
+ Partials 5179 5177 -2
|
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-use-redis-getset-over-a-lock-for-synchronization
branch
from
b135552
to
0747aef
Compare
JoshFerge
approved these changes
Aug 8, 2023
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-use-redis-getset-over-a-lock-for-synchronization
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking a lock when ticking the monitor tasks trigger clock,
we can use redis'
GETSETcommand to retrieve the current value and seta new value atomically.
This addresses @fpacifici's feedback here #53661 (comment)