feat(crons): Switch to clock driven monitor task dispatch #54335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
davidenwang
reviewed
Aug 8, 2023
| # running the monitor tasks. These tasks are responsible for creating missed | ||
| # check-ins and marking timedout check-ins. Thus, having some delay after the | ||
| # start of the minute is critical. | ||
| MONITOR_TASK_DELAY = 15 |
There was a problem hiding this comment.
quick question about this, i know before we changed the logic of the check_missing task to only mark missing tasks that were already a minute past due. E.g. at 11:01pm it would mark the 11:00pm expected scheduled cron job as missing. Do we just want this extra 15 seconds as additional safety or has some other logic changed along with this?
There was a problem hiding this comment.
Did we actually do that?
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-switch-to-clock-driven-monitor-task-dispatch
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #53661
This should not be done until we're confident in in the system correctly ticking