-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github): detecting fatal error for disabling integrations #54286
feat(github): detecting fatal error for disabling integrations #54286
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54286 +/- ##
===========================================
+ Coverage 54.33% 79.87% +25.54%
===========================================
Files 5010 5025 +15
Lines 213416 213821 +405
Branches 36314 36374 +60
===========================================
+ Hits 115950 170796 +54846
+ Misses 94501 37786 -56715
- Partials 2965 5239 +2274
|
) or ( | ||
features.has("organizations:github-disable-on-broken", org) | ||
and rpc_integration.provider == "github" | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be doing a similar check for is_integration_fatal_broken
if it is github or is that smth we only want to do for slack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ it doesn't seem like we're checking if it's broken before disabling right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is within the disable function which is called after buffer.is_integration_broken()
is True
. We did is_integration_fatal_broken
for slack since we wanted to turn on the slack flag but only validated the fatal broken integrations. I'm not sure if we will have the same situation with github but we can see what we get in the logging and then decide?
Storing fatal error for disabling Github integrations
Milestone 3 of Notify on Disabled Integration project