feat(tracing-without-performance): Returned orphan errors with trace …

[Abdkhan14]

For the ticket: https://getsentry.atlassian.net/browse/PERF-2052.

• We want to add new rows to trace views for traces that contain orphan errors. Currently the trace endpoint ignores orphan errors.
  

• This PR aims to append orphan errors to the response of the trace endpoint and should work for both scenarios:

• • Only errors in trace (Scenario 3 from image above).
• • Mixup of errors and transactions (Scenario 2 from image above).

• Returning event_type:"error" and generation:0 with all errors, to help us identify the orphan errors in the frontend and always group them under the first generation.

• Added tests for both scenarios.

[codecov]

Codecov Report

Merging #54103 (1a9d6d4) into master (9d2000a) will decrease coverage by 0.01%.
Report is 15 commits behind head on master.
The diff coverage is 76.47%.

❗ Current head 1a9d6d4 differs from pull request most recent head b906096. Consider uploading reports for the commit b906096 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #54103      +/-   ##
==========================================
- Coverage   79.60%   79.60%   -0.01%     
==========================================
  Files        4983     4983              
  Lines      210531   210543      +12     
  Branches    35846    35851       +5     
==========================================
+ Hits       167593   167597       +4     
- Misses      37795    37801       +6     
- Partials     5143     5145       +2     

Files Changed	Coverage Δ
static/app/utils/discover/fieldRenderers.tsx	74.33% <ø> (ø)
static/app/utils/formatters.tsx	96.46% <ø> (-0.10%)	⬇️
...views/performance/landing/chart/histogramChart.tsx	12.12% <ø> (ø)
static/app/views/performance/landing/utils.tsx	57.81% <ø> (ø)
...transactionSummary/transactionVitals/vitalCard.tsx	54.54% <ø> (ø)
.../sentry/api/endpoints/organization_events_trace.py	89.27% <76.47%> (-0.62%)	⬇️

... and 6 files with indirect coverage changes

[k-fish]

Aside from my suggestion to minimize passed params, looks good 👍

[narsaynorath]

+1 to Kevan's comment. Nice changes!

[sentry-io]

Suspect Issues

This pull request has been deployed and Sentry observed the following issues:

• ‼️ AssertionError: assert {'event_id': '3ca762903e854511946218a137e63bce', 'event_type': 'error', 'generation': 0, '... pytest.runtest.protocol tests/snuba/api/endpoin... View Issue
• ‼️ AssertionError: assert {'event_id': 'e3756f07029f455ebff69534b0b00b1e', 'event_type': 'error', 'generation': 0, '... pytest.runtest.protocol tests/snuba/api/endpoin... View Issue
• ‼️ AssertionError: assert {'event_id': '63aa8568245f429caf499d23cd868b40', 'issue_id': 48, 'span': '0076af953b694a66... pytest.runtest.protocol tests/snuba/api/endpoin... View Issue

_{Did you find this useful? React with a 👍 or 👎}