Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starfish): Handle free text search #54060

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

wmak
Copy link
Member

@wmak wmak commented Aug 2, 2023

  • This fixes free text search on the span-metrics dataset so instead of handling something like query:test abc as message:"test abc" it'll now be handled as span.description:"test abc"
  • This also identifies an issue with the metric layer where tag searching like this isn't supported

- This fixes free text search on the span-metrics dataset so instead of
  handling something like query:`test abc` as `message:"test abc"` it'll
  now be handled as `span.description:"test abc"`
- This also identifies an issue with the metric layer where tag
  searching like this isn't supported
@wmak wmak requested a review from a team August 2, 2023 20:55
@wmak wmak marked this pull request as ready for review August 2, 2023 20:55
@wmak wmak requested a review from a team August 2, 2023 20:55
@wmak wmak requested a review from a team as a code owner August 2, 2023 20:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #54060 (2371efe) into master (e658f63) will increase coverage by 0.03%.
Report is 74 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 2371efe differs from pull request most recent head b9b461e. Consider uploading reports for the commit b9b461e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #54060      +/-   ##
==========================================
+ Coverage   79.53%   79.57%   +0.03%     
==========================================
  Files        4974     4984      +10     
  Lines      210394   210775     +381     
  Branches    35836    35888      +52     
==========================================
+ Hits       167339   167717     +378     
- Misses      37907    37908       +1     
- Partials     5148     5150       +2     
Files Changed Coverage Δ
...tatic/app/views/replays/replayTable/headerCell.tsx 66.66% <ø> (ø)
static/app/views/replays/replayTable/index.tsx 88.23% <ø> (ø)
static/app/views/replays/replayTable/tableCell.tsx 88.88% <ø> (ø)
src/sentry/search/events/builder/spans_metrics.py 42.10% <100.00%> (+2.10%) ⬆️

... and 66 files with indirect coverage changes

@wmak wmak enabled auto-merge (squash) August 3, 2023 16:09
@wmak wmak merged commit 4cee72d into master Aug 3, 2023
55 checks passed
@wmak wmak deleted the wmak/fix/handle-free-text-search-on-starfish branch August 3, 2023 16:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants