feat(backup): Add DateAddedComparator #54009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #54009 +/- ##
==========================================
+ Coverage 79.60% 79.62% +0.01%
==========================================
Files 4983 4985 +2
Lines 210545 210743 +198
Branches 35853 35890 +37
==========================================
+ Hits 167599 167795 +196
+ Misses 37800 37798 -2
- Partials 5146 5150 +4
|
hubertdeng123
approved these changes
Aug 2, 2023
This comparator accounts for the fact that old JSON exports may have zero millisecond timestamps formatted without the `.000`, as Python is wont to do in its natural datetime serializer. We have since replaced this default behavior with more consistent behavior that always includes the milliseconds, but to work with old exports, we still need to use this comparator. Closes getsentry/team-ospo#155
azaslavsky
force-pushed
the
azaslavsky/backups/date_added
branch
from
2966127
to
a781ed9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comparator accounts for the fact that old JSON exports may have zero millisecond timestamps formatted without the
.000, as Python is wont to do in its natural datetime serializer. We have since replaced this default behavior with more consistent behavior that always includes the milliseconds, but to work with old exports, we still need to use this comparator.Closes getsentry/team-ospo#155