Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mypy): fix mypy errors for src/sentry/api/serializers/models (part 1) #53905

Merged
merged 8 commits into from
Aug 3, 2023

Conversation

hubertsentry
Copy link
Contributor

Fix mypy errors under src/sentry/api/serializers/models

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #53905 (ff578f5) into master (903f7b4) will decrease coverage by 0.02%.
Report is 11 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53905      +/-   ##
==========================================
- Coverage   79.61%   79.60%   -0.02%     
==========================================
  Files        4984     4983       -1     
  Lines      210736   210531     -205     
  Branches    35877    35846      -31     
==========================================
- Hits       167779   167590     -189     
+ Misses      37809    37798      -11     
+ Partials     5148     5143       -5     
Files Changed Coverage Δ
...pp/components/events/eventReplay/replayPreview.tsx 100.00% <ø> (ø)
...nents/replays/breadcrumbs/replayTimelineEvents.tsx 0.00% <ø> (ø)
static/app/components/replays/replayContext.tsx 45.37% <ø> (ø)
static/app/components/replays/utils.tsx 90.00% <ø> (-0.70%) ⬇️
...atic/app/components/replays/walker/splitCrumbs.tsx 100.00% <ø> (ø)
...tatic/app/utils/replays/hooks/useCrumbHandlers.tsx 87.50% <ø> (+50.65%) ⬆️
static/app/utils/replays/replayDataUtils.tsx 100.00% <ø> (+12.90%) ⬆️
static/app/utils/replays/replayReader.tsx 60.00% <ø> (-15.00%) ⬇️
...entry/api/serializers/models/alert_rule_trigger.py 100.00% <100.00%> (ø)
src/sentry/api/serializers/models/commit.py 93.22% <100.00%> (ø)
... and 5 more

... and 14 files with indirect coverage changes

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

src/sentry/api/serializers/models/release_file.py Outdated Show resolved Hide resolved
src/sentry/api/serializers/models/tagvalue.py Outdated Show resolved Hide resolved
@hubertsentry hubertsentry marked this pull request as ready for review August 1, 2023 20:29
@hubertsentry hubertsentry requested a review from a team August 1, 2023 20:29
@hubertsentry hubertsentry requested a review from a team as a code owner August 1, 2023 20:29
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hubertsentry
Copy link
Contributor Author

Sorry, it took longer then I thought. It seems like one of my change caused openapi-diff issue. My change is probably doing the right thing, however, it will make api schema incompatible. Let me revert the change for that file now, I will see how I can address the issue later.

@hubertsentry hubertsentry merged commit de4f902 into master Aug 3, 2023
56 checks passed
@hubertsentry hubertsentry deleted the fix/fix-mypy-api-serializers-models-p1 branch August 3, 2023 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants