Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: require choices for ChoiceField to be a Sequence #53707

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Jul 27, 2023

when these are unordered collections it causes api-diff to flap.

fixed the one error that was outstanding:

src/sentry/replays/validators.py:56: error: Argument "choices" to "MultipleChoiceField" has incompatible type "Set[str]"; expected "Sequence[Any]"  [arg-type]

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #53707 (3f82f76) into master (6ce9614) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53707      +/-   ##
==========================================
- Coverage   79.50%   79.50%   -0.01%     
==========================================
  Files        4951     4951              
  Lines      209200   209200              
  Branches    35637    35637              
==========================================
- Hits       166328   166324       -4     
- Misses      37784    37789       +5     
+ Partials     5088     5087       -1     
Files Changed Coverage Δ
src/sentry/replays/validators.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@asottile-sentry asottile-sentry merged commit af88fdf into master Jul 27, 2023
57 of 58 checks passed
@asottile-sentry asottile-sentry deleted the asottile-serializers-choices-sequence branch July 27, 2023 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants