Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(replay): Remove unicode from slack View Replays link #53518

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jul 25, 2023

The unicode doesn't display properly on all devices

Example of it not working:
Screen Shot 2023-07-25 at 9 38 52 AM

Here's where it does work:
SCR-20230725-iivp

@ryan953 ryan953 requested a review from a team as a code owner July 25, 2023 15:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #53518 (3182b77) into master (a1810c3) will increase coverage by 3.39%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53518      +/-   ##
==========================================
+ Coverage   76.15%   79.55%   +3.39%     
==========================================
  Files        4940     4943       +3     
  Lines      208697   209151     +454     
  Branches    35548    35618      +70     
==========================================
+ Hits       158941   166389    +7448     
+ Misses      44595    37672    -6923     
+ Partials     5161     5090      -71     
Files Changed Coverage Δ
src/sentry/integrations/message_builder.py 100.00% <100.00%> (+6.09%) ⬆️

... and 490 files with indirect coverage changes

@ryan953 ryan953 merged commit 3f9b110 into master Jul 25, 2023
57 checks passed
@ryan953 ryan953 deleted the ryan953/replay-slack-issue-no-unicode branch July 25, 2023 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants