feat(starfish): Replaces usage of p95 in the Database Module with avg #53515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
Some of these changes also affect parts of the WSV workflow due to shared components. We can complete the move from p95 in the WSV to avg in a separate future pr since WSV is still undergoing redesign. |
…tarfish/replace-p95-with-avg
gggritso
approved these changes
Jul 25, 2023
| @@ -191,7 +191,9 @@ export function TransactionSamplesTable({queryConditions, sampleFilter}: Props) | |||
| return ( | |||
| <DurationComparisonCell | |||
| duration={row['transaction.duration']} | |||
| p95={(aggregatesData?.['p95(transaction.duration)'] as number) ?? 0} | |||
| compareToDuration={ | |||
| (aggregatesData?.['p95(transaction.duration)'] as number) ?? 0 | |||
There was a problem hiding this comment.
Should this also be avg() or is this out of scope?
There was a problem hiding this comment.
I think I'm going to consider this to be out of scope for this pr. This component is part of the WSV/Endpoint overview so I'll follow up with updating this in a separate pr when it becomes a necessity.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces usage of p95 in the Database Module with avg in the frontend. Also cleans ups some types and column related constants.