Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic-sampling): Add project slug to response of AM2 check #53514

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jul 25, 2023

This PR adds the project slugs in the API response for the am2 compatibility check.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 25, 2023
@iambriccardo iambriccardo marked this pull request as ready for review July 25, 2023 14:00
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #53514 (51f2385) into master (64fba06) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53514      +/-   ##
==========================================
- Coverage   79.55%   79.55%   -0.01%     
==========================================
  Files        4942     4942              
  Lines      209068   209067       -1     
  Branches    35603    35604       +1     
==========================================
- Hits       166331   166329       -2     
  Misses      37658    37658              
- Partials     5079     5080       +1     
Files Changed Coverage Δ
src/sentry/tasks/check_am2_compatibility.py 59.72% <100.00%> (-0.19%) ⬇️

... and 2 files with indirect coverage changes

@iambriccardo iambriccardo merged commit 069cdc5 into master Jul 25, 2023
58 checks passed
@iambriccardo iambriccardo deleted the riccardo/feat/improve-check branch July 25, 2023 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants