ref(hybrid-cloud): Fix a few tests in split silo mode #53482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53482 +/- ##
==========================================
- Coverage 79.54% 78.24% -1.31%
==========================================
Files 4942 4917 -25
Lines 208669 208829 +160
Branches 35551 35568 +17
==========================================
- Hits 165988 163389 -2599
- Misses 37617 40232 +2615
- Partials 5064 5208 +144
|
corps
approved these changes
Jul 25, 2023
chloeho7
pushed a commit
that referenced
this pull request
Jul 25, 2023
This avoid passing QuerySet objects into RPC methods, and also marks as safe an RPC read that happens in a transaction. Normally we would work to avoid the latter, but this particular one is nested fairly deeply inside the transaction. We may circle back to it. --------- Co-authored-by: Zachary Collins <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid passing QuerySet objects into RPC methods, and also marks as safe an RPC read that happens in a transaction. Normally we would work to avoid the latter, but this particular one is nested fairly deeply inside the transaction. We may circle back to it.