ref(grouping): Clean up message normalization #53479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53479 +/- ##
==========================================
+ Coverage 79.42% 79.54% +0.12%
==========================================
Files 4941 4941
Lines 208741 208794 +53
Branches 35558 35559 +1
==========================================
+ Hits 165789 166094 +305
+ Misses 37881 37635 -246
+ Partials 5071 5065 -6
|
chloeho7
pushed a commit
that referenced
this pull request
Jul 25, 2023
This is a refactor intended to make the code handling exception messages in the grouping algorithm a little easier to work with, by adding/clarifying comments and changing names to be more reflective of their namees' respective purposes. The only behavior change is that the hint for message parameterization (shown in the grouping info section of the issue details page) has been changed from `Stripped common values` to `Stripped event-specific values`, since the whole point of parameterization is to remove values which different events _don't_ have in common. (All of the snapshot changes are related to this switch.) The rest of the changes are just renamings, the main theme being to change our language from talking about "trimming" to talking about "normalization," since we both shorten and parameterize the event's message before using it for grouping.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor intended to make the code handling exception messages in the grouping algorithm a little easier to work with, by adding/clarifying comments and changing names to be more reflective of their namees' respective purposes. The only behavior change is that the hint for message parameterization (shown in the grouping info section of the issue details page) has been changed from
Stripped common valuestoStripped event-specific values, since the whole point of parameterization is to remove values which different events don't have in common. (All of the snapshot changes are related to this switch.)The rest of the changes are just renamings, the main theme being to change our language from talking about "trimming" to talking about "normalization," since we both shorten and parameterize the event's message before using it for grouping.