feat(dnd-worldmap-removal) Added null checks for columns and fields. #53475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
Jul 24, 2023
•
Abdkhan14
commented
- Migration already approved here: PR but it had a runtime error.
- Added null checks for columns and fields in DashboardWidgetQuery.
- Should fix run time error from previous migration attempt:
- Link to failure: https://deploy.getsentry.net/go/tab/build/detail/deploy-getsentry-backend-us/63/migrations/1/migrations
- Tested it out locally with NULL columns.
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53475 +/- ##
==========================================
- Coverage 79.55% 78.24% -1.32%
==========================================
Files 4942 4917 -25
Lines 209068 208787 -281
Branches 35603 35562 -41
==========================================
- Hits 166331 163355 -2976
- Misses 37658 40222 +2564
- Partials 5079 5210 +131 |
markstory
approved these changes
Jul 25, 2023
Comment on lines
11
to
13
| widgetQueries = DashboardWidgetQuery.objects.select_related("widget").filter( | ||
| widget__display_type=5 | ||
| ) |
There was a problem hiding this comment.
You're around the 10k row count. You could hit a migration timeout when updating rows. If you wanted to be totally safe an is_dangerous = True migration would safer albeit much slower.
There was a problem hiding this comment.
Yeah I'd rather be safe. How much longer would it take @markstory?
|
This PR has a migration; here is the generated SQL for --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
chloeho7
pushed a commit
that referenced
this pull request
Jul 25, 2023
…53475) - Migration already approved here: [PR](#53109) but it had a runtime error. - Added null checks for columns and fields in DashboardWidgetQuery. - Should fix run time error from previous migration attempt: <img width="488" alt="Screenshot 2023-07-24 at 6 17 48 PM" src="https://github.com/getsentry/sentry/assets/60121741/49fe3214-77c3-4bdb-b02f-355eb567f1d3"> - Link to failure: https://deploy.getsentry.net/go/tab/build/detail/deploy-getsentry-backend-us/63/migrations/1/migrations - Tested it out locally with NULL columns. Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.