Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(starfish): add transaction.op:http.server to webservice queries #53355

Merged
merged 4 commits into from
Jul 25, 2023
Merged

feat(starfish): add transaction.op:http.server to webservice queries #53355

merged 4 commits into from
Jul 25, 2023

Conversation

DominikB2014
Copy link
Contributor

I also double checked mobile, currently it does not use useSpansQuery, but instead uses traditional HOC, so no need to update anything there yet.

@DominikB2014 DominikB2014 requested a review from a team July 21, 2023 18:06
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 21, 2023
gggritso
gggritso reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to use an existing enum for the view type 👍🏻

static/app/views/starfish/utils/useSpansQuery.tsx Outdated Show resolved Hide resolved
gggritso
gggritso approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@DominikB2014 DominikB2014 merged commit 0e3d1f3 into master Jul 25, 2023
49 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/add-transaction-op branch July 25, 2023 15:05
chloeho7 pushed a commit that referenced this pull request Jul 25, 2023
@DominikB2014 @chloeho7
feat(starfish): add transaction.op:http.server to webservice queries (#…
824ca44 
…53355)

I also double checked mobile, currently it does not use `useSpansQuery`,
but instead uses traditional HOC, so no need to update anything there
yet.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominikB2014 @gggritso