feat(integration-slack): store request error counts and disable on broken #52994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52994 +/- ##
==========================================
+ Coverage 76.07% 79.54% +3.46%
==========================================
Files 4942 4942
Lines 209107 208946 -161
Branches 35613 35593 -20
==========================================
+ Hits 159082 166206 +7124
+ Misses 44779 37662 -7117
+ Partials 5246 5078 -168
|
ceorourke
reviewed
Jul 17, 2023
chloeho7
added a commit
that referenced
this pull request
Jul 25, 2023
…oken (#52994) Continuing #51126 Milestone 1 of [Notify on Disabled Integration project ](https://www.notion.so/sentry/Tech-Spec-Notify-on-Disabled-Integration-Spec-e7ea0f86ccd6419cb3e564067cf4a2ef?pvs=4 ) Implementing `IntegrationRequestBuffer` using Redis for logging errors and detecting broken integrations to be disabled. Request buffer stores daily aggregate error, fatal and success counts for an integration for 30 days. If an integration consistently fails for 7 days or has a fatal response, then the integration is broken. Later users will be alerted of broken integrations with an email or in-app. Disabling implemented under feature flag `"disable-on-broken"`. Conditions for logging Implemented in `BaseApiClient` and `SlackClient`. --------- Co-authored-by: Colleen O'Rourke <[email protected]>
|
PR reverted: 8ae2b10 |
getsentry-bot
added a commit
that referenced
this pull request
Jul 25, 2023
…le on broken (#52994)" This reverts commit 75d6446. Co-authored-by: scefali <[email protected]>
This was referenced Jul 26, 2023
chloeho7
added a commit
that referenced
this pull request
Jul 27, 2023
…oken (#53621) Continuing #52994 after revert > > Continuing #51126 > Milestone 1 of [Notify on Disabled Integration project](https://www.notion.so/sentry/Tech-Spec-Notify-on-Disabled-Integration-Spec-e7ea0f86ccd6419cb3e564067cf4a2ef?pvs=4) > > Implementing IntegrationRequestBuffer using Redis for logging errors and detecting broken integrations to be disabled. Request buffer stores daily aggregate error, fatal and success counts for an integration for 30 days. If an integration consistently fails for 7 days or has a fatal response, then the integration is broken. Later users will be alerted of broken integrations with an email or in-app. > > Disabling implemented under feature flag "slack-disable-on-broken". > Conditions for logging Implemented in BaseApiClient and SlackClient. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> Co-authored-by: Colleen O'Rourke <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #51126
Milestone 1 of Notify on Disabled Integration project
Implementing
IntegrationRequestBufferusing Redis for logging errors and detecting broken integrations to be disabled. Request buffer stores daily aggregate error, fatal and success counts for an integration for 30 days. If an integration consistently fails for 7 days or has a fatal response, then the integration is broken. Later users will be alerted of broken integrations with an email or in-app.Disabling implemented under feature flag
"slack-disable-on-broken".Conditions for logging Implemented in
BaseApiClientandSlackClient.