Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix typing for sentry.models.__init__ #52992

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

asottile-sentry
Copy link
Member

star imports were clobbering names with incompatible types

star imports were clobbering names with incompatible types
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #52992 (65ceb7f) into master (14d014a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #52992      +/-   ##
==========================================
+ Coverage   79.38%   79.45%   +0.06%     
==========================================
  Files        4935     4936       +1     
  Lines      207327   207436     +109     
  Branches    35422    35439      +17     
==========================================
+ Hits       164586   164809     +223     
+ Misses      37705    37586     -119     
- Partials     5036     5041       +5     
Impacted Files Coverage Δ
static/app/views/organizationDetails/index.tsx 100.00% <ø> (ø)
...views/settings/project/navigationConfiguration.tsx 35.71% <ø> (ø)
src/sentry/api/endpoints/filechange.py 62.96% <100.00%> (+1.42%) ⬆️
.../sentry/api/endpoints/organization_release_meta.py 77.77% <100.00%> (+0.85%) ⬆️
src/sentry/api/endpoints/organization_users.py 100.00% <100.00%> (ø)
src/sentry/api/serializers/models/filechange.py 100.00% <100.00%> (ø)
...zers/models/organization_member/expand/projects.py 100.00% <100.00%> (ø)
src/sentry/api/serializers/models/project.py 96.19% <100.00%> (+<0.01%) ⬆️
src/sentry/api/serializers/models/team.py 93.93% <100.00%> (+0.03%) ⬆️
...rc/sentry/api/serializers/rest_framework/commit.py 100.00% <100.00%> (ø)
... and 18 more

... and 21 files with indirect coverage changes

@asottile-sentry asottile-sentry marked this pull request as ready for review July 17, 2023 18:15
@asottile-sentry asottile-sentry requested review from a team as code owners July 17, 2023 18:15
@asottile-sentry asottile-sentry requested a review from a team July 17, 2023 18:15
@asottile-sentry asottile-sentry requested a review from a team as a code owner July 17, 2023 18:15
@asottile-sentry asottile-sentry requested review from a team July 17, 2023 18:15
@asottile-sentry asottile-sentry enabled auto-merge (squash) July 17, 2023 18:17
@asottile-sentry asottile-sentry merged commit 4889710 into master Jul 17, 2023
@asottile-sentry asottile-sentry deleted the asottile-mypy-models branch July 17, 2023 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants