ref(event_manager): Fix typing issues for event_manager #52974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make a lot of changes to event_manager and we need to have backend typing in place for the upcoming work. Fixes #52877
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52974 +/- ##
==========================================
- Coverage 79.38% 77.76% -1.62%
==========================================
Files 4935 4934 -1
Lines 207336 207428 +92
Branches 35424 35443 +19
==========================================
- Hits 164586 161312 -3274
- Misses 37714 41071 +3357
- Partials 5036 5045 +9
|
asottile-sentry
requested changes
Jul 17, 2023
src/sentry/event_manager.py
Outdated
| @@ -2155,7 +2139,7 @@ def save_attachment( | |||
| type=attachment.type, | |||
| headers={"Content-Type": attachment.content_type}, | |||
| ) | |||
| file.putfile(BytesIO(data), blob_size=settings.SENTRY_ATTACHMENT_BLOB_SIZE) | |||
| file.putfile(BytesIO(data), blob_size=settings.SENTRY_ATTACHMENT_BLOB_SIZE) # type: ignore | |||
There was a problem hiding this comment.
(I think this got lost from the other review but want to make sure it gets addressed)
the problem here is the type alias above -- it shouldn't be Type[Cached...] ( don't remember the name and it's offscreen) -- the type alias should probably be removed entirely at that point since it'll just be A = B and just meaningless indirection
src/sentry/event_manager.py
Outdated
| @@ -2266,7 +2250,8 @@ def _calculate_event_grouping( | |||
| event.data["grouping_config"] = get_grouping_config_dict_for_project(project) | |||
| hashes = event.get_hashes() | |||
|
|
|||
| hashes.write_to_event(event.data) | |||
| # Using cast to satisfy mypy | |||
| hashes.write_to_event(cast(Dict[str, Any], event.data)) | |||
There was a problem hiding this comment.
the types should get updated here rather than cast -- cast and type: ignore should generally only be used for mypy bugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make a lot of changes to event_manager and we need to have backend typing in place for the upcoming work.
Fixes #52877