Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(discord): Change log level from error to info for unauthorized interactions #52946

Merged
merged 5 commits into from
Jul 17, 2023
Merged

fix(discord): Change log level from error to info for unauthorized interactions #52946

merged 5 commits into from
Jul 17, 2023

Conversation

spalmurray
Copy link
Contributor

@spalmurray spalmurray commented Jul 15, 2023 •
edited
Loading

Receiving unauthorized transactions should not cause an issue in Sentry.

Fixes SENTRY-13A0

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 15, 2023 •
edited
Loading

Codecov Report

Merging #52946 (c9ca708) into master (7b24e6a) will decrease coverage by 3.51%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #52946      +/-   ##
==========================================
- Coverage   79.45%   75.94%   -3.51%     
==========================================
  Files        4936     4933       -3     
  Lines      207380   207278     -102     
  Branches    35426    35419       -7     
==========================================
- Hits       164769   157421    -7348     
- Misses      37571    44798    +7227     
- Partials     5040     5059      +19
Impacted Files Coverage Δ
src/sentry/integrations/discord/requests/base.py 77.61% <0.00%> (-22.39%) ⬇️
...ic/app/views/issueDetails/quickTrace/traceLink.tsx 62.50% <ø> (ø)

... and 471 files with indirect coverage changes

@spalmurray spalmurray marked this pull request as ready for review July 17, 2023 15:20
@spalmurray spalmurray requested a review from a team as a code owner July 17, 2023 15:20
@spalmurray spalmurray requested a review from snigdhas July 17, 2023 15:20
@spalmurray spalmurray self-assigned this Jul 17, 2023
@spalmurray spalmurray enabled auto-merge (squash) July 17, 2023 18:25
@spalmurray spalmurray merged commit 36a2de6 into master Jul 17, 2023
@spalmurray spalmurray deleted the spalmurray/discord-fix-auth-error branch July 17, 2023 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

@snigdhas snigdhas Awaiting requested review from snigdhas

Assignees

@spalmurray spalmurray

Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalmurray @scttcper @spalmurray-codecov