fix(releases): Use query parameter when switching filters #52937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a large ternary with a mistake setting the current filter to state. We can use the query parameter instead of state.
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Jul 15, 2023
Comment on lines
-90
to
-91
| : query.includes(IssuesType.REGRESSED) | ||
| ? IssuesType.UNHANDLED |
There was a problem hiding this comment.
This was the mistake, but the real mistake was this massive ternary
scttcper
commented
Jul 15, 2023
| @@ -56,7 +56,6 @@ type Props = { | |||
| location: Location; | |||
| organization: Organization; | |||
| releaseBounds: ReleaseBounds; | |||
| selection: PageFilters; | |||
malwilley
approved these changes
Jul 17, 2023
| RESOLVED = 'is:resolved', | ||
| ALL = 'release', | ||
| } | ||
| const IssuesQuery: Record<IssuesType, string> = { |
There was a problem hiding this comment.
nit: should this still be pascal case now that it's not an enum?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a large ternary with a mistake setting the current filter to the wrong option. We can use the query parameter instead of state altogether.
fixes #52880