Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replays): fix bin/mock-replays script #52927

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Jul 14, 2023

Closes getsentry/team-replay#115

bin/mock-replays script now runs successfully locally so you can see an empty replay in your local environment upon running sentry devserver

@michellewzhang
Copy link
Member Author

michellewzhang commented Jul 14, 2023

Some future work that needs to be added upon this fix:

Priority TODOs

  • Alert the user if the replay feature flag is not on (this needs to be added to your local sentry.conf.py file)
  • Make the created project a Javascript project by default (currently, trying to switch it to Javascript gives an error)
  • Assign the project to the default team (currently, not assigned by default)

Nice to have TODOs

  • Replay video contains rage clicks and dead clicks (and isn't just an empty video)

@michellewzhang michellewzhang requested a review from a team July 14, 2023 22:42
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great stuff! 🥳

@michellewzhang michellewzhang merged commit 14da39a into master Jul 17, 2023
@michellewzhang michellewzhang deleted the mz/fix-mock-script branch July 17, 2023 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants