feat(grouping): Add metrics for issue merging and unmerging #52919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lobsterkatie
force-pushed
the
kmclb-add-issue-merging-metric
branch
from
4bc4ce9
to
fae89c2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52919 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 4934 4934
Lines 207215 207223 +8
Branches 35403 35403
=======================================
+ Hits 164481 164493 +12
+ Misses 37704 37701 -3
+ Partials 5030 5029 -1
|
lobsterkatie
force-pushed
the
kmclb-add-issue-merging-metric
branch
from
fae89c2
to
4c1d292
Compare
armenzg
approved these changes
Jul 17, 2023
| @@ -61,6 +62,13 @@ def delete(self, request: Request, group) -> Response: | |||
| if not hash_list: | |||
| return Response() | |||
|
|
|||
| metrics.incr( | |||
| "grouping.unmerge_issues", | |||
There was a problem hiding this comment.
I'm really interested on knowing how many people actually unmerge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds DataDog metrics for instances of issues being merged and unmerged. Both metrics include the issues' platform, and the merge metric additionally includes referer (since you can merge from either the issue stream or the Similar Issues tab). A few missing merge-related tests were also added.
Note: I was originally going to include the number of issues being merged as extra data for the merging metric, but it occurred to me that people are more likely to merge in new issues as they appear rather than wait and merge all the issues at once, so I removed it. We can revisit this later if necessary.
Ref: #52920
Ref: #52922