Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crons): Properly checks for environment name lengths #52820

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Jul 13, 2023

Safety check for environment name lengths

Related relay PR getsentry/relay#2309
Closes SENTRY-1351

@rjo100 rjo100 requested a review from a team as a code owner July 13, 2023 18:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #52820 (c650350) into master (b3f6334) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #52820   +/-   ##
=======================================
  Coverage   79.46%   79.46%           
=======================================
  Files        4936     4936           
  Lines      207392   207415   +23     
  Branches    35422    35426    +4     
=======================================
+ Hits       164796   164815   +19     
- Misses      37560    37563    +3     
- Partials     5036     5037    +1     
Impacted Files Coverage Δ
...c/app/views/organizationStats/usageChart/utils.tsx 52.08% <ø> (ø)
src/sentry/monitors/consumers/monitor_consumer.py 89.47% <100.00%> (+0.25%) ⬆️
...monitors/endpoints/monitor_ingest_checkin_index.py 94.50% <100.00%> (ø)
src/sentry/monitors/models.py 92.90% <100.00%> (+0.09%) ⬆️

... and 13 files with indirect coverage changes

@rjo100 rjo100 merged commit c0c3a28 into master Jul 17, 2023
@rjo100 rjo100 deleted the rjo100/checkin-env-name-validation branch July 17, 2023 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants