Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(starfish): Time spent local was always querying light time spent #52374

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix(starfish): Time spent local was always querying light time spent #52374

merged 3 commits into from
Jul 6, 2023

Conversation

shruthilayaj
Copy link
Member

This was because the where condition & groupby was being resolved
after the base query is resolved and the if transaction was in any
of those two things, the fallback to span.exclusive_time doesn't
get picked up

@shruthilayaj shruthilayaj requested a review from a team July 6, 2023 18:45
@shruthilayaj shruthilayaj requested a review from a team as a code owner July 6, 2023 18:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 6, 2023
@shruthilayaj shruthilayaj requested a review from a team July 6, 2023 18:46
@shruthilayaj shruthilayaj enabled auto-merge (squash) July 6, 2023 18:51
@shruthilayaj shruthilayaj merged commit 4434192 into master Jul 6, 2023
@shruthilayaj shruthilayaj deleted the shruthi/fix/time-spent-local-metric branch July 6, 2023 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wmak wmak wmak approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shruthilayaj @wmak