Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starfish): API module consistency and continuity updaes #52347

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

edwardgou-sentry
Copy link
Contributor

Adds 5xx elements to api span summaries. This is to keep consistent data displayed to users across the module and span summary view.
Sorts the spans table in the module view when zooming in on a throughput, p95, or error chart.

@edwardgou-sentry edwardgou-sentry requested a review from a team July 6, 2023 15:29
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 6, 2023
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, nice! Just a small typo in component name

@edwardgou-sentry edwardgou-sentry merged commit 0fd919c into master Jul 6, 2023
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/starfish/api-module-continuity branch July 6, 2023 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants