feat(slack): slack channel lookup via schedule message #52034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52034 +/- ##
==========================================
- Coverage 77.72% 76.95% -0.78%
==========================================
Files 4883 4909 +26
Lines 205442 205816 +374
Branches 35126 35181 +55
==========================================
- Hits 159681 158378 -1303
- Misses 40650 42321 +1671
- Partials 5111 5117 +6
|
scefali
reviewed
Jun 30, 2023
scefali
reviewed
Jun 30, 2023
scefali
reviewed
Jun 30, 2023
scefali
reviewed
Jun 30, 2023
scefali
reviewed
Jun 30, 2023
ceorourke
reviewed
Jul 5, 2023
src/sentry/features/__init__.py
Outdated
| @@ -256,6 +256,7 @@ | |||
| default_manager.add("organizations:ds-sliding-window-org", OrganizationFeature, FeatureHandlerStrategy.INTERNAL) | |||
| default_manager.add("organizations:pr-comment-bot", OrganizationFeature, FeatureHandlerStrategy.REMOTE) | |||
| default_manager.add("organizations:ds-org-recalibration", OrganizationFeature, FeatureHandlerStrategy.INTERNAL) | |||
| default_manager.add("organizations:slack-use-new-lookup", OrganizationFeature, FeatureHandlerStrategy.INTERNAL) | |||
There was a problem hiding this comment.
You'll want this to be FeatureHandlerStrategy.REMOTE so that we can enable the feature using Flagr. https://develop.sentry.dev/feature-flags/#add-your-feature-to-the-featuremanager
I can help you set up the feature flag in Flagr too :)
ceorourke
reviewed
Jul 6, 2023
|
This looks so good! I'll give it one last pass tomorrow and I can explain how to set up the feature flag in Flagr |
ceorourke
approved these changes
Jul 6, 2023
chloeho7
changed the title
chloeho7
changed the title
chloeho7
added a commit
that referenced
this pull request
Aug 2, 2023
Fixes #52034 Don't reset the pagination cursor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51882
Using slack api chat.scheduleMessage in get_channel_id_with_timeout_new function to lookup channel id