ref(ui): Extract LoadingTriangle from LoadingIndicator #31118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f9fc2a.
priscilawebdev
approved these changes
Jan 14, 2022
|
because we have already fixed the issue in the hotfix https://github.com/getsentry/getsentry/pull/6871 it's fine to merge this code again, right? |
|
Yes everything should be fixed now. I'll merge and verify 🙏 |
evanpurkhiser
deleted the
evanpurkhiser/ref-ui-extract-loadingtriangle-from-loadingindicator
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7f9fc2a.
Follow up to #31111