feat(profiling): add text renderer #31108
Conversation
JonasBa
force-pushed
the
jb/profiling/text-renderer
branch
from
c193cd4
to
d8e40d0
Compare
JonasBa
force-pushed
the
jb/profiling/text-renderer
branch
from
d8e40d0
to
162bad8
Compare
JonasBa
force-pushed
the
jb/profiling/text-renderer
branch
from
162bad8
to
c2323ef
Compare
| @@ -198,13 +198,13 @@ export class Rect { | |||
| return this.x; | |||
| } | |||
| get right(): number { | |||
| return this.left + this.width; | |||
| return this.x + this.width; | |||
There was a problem hiding this comment.
Is there a reason to prefer this.x over this.left? Also if they refer to the same value, can we consolidate this and strictly use this.left and that's more explicit compared to this.x.
There was a problem hiding this comment.
Yeah, you are right. Left is mostly here because we also have "right", so left is basically a duplicate of x and right is the useful one. I think I originally added it just because it made sense to cover all the coordinates as I added the right and bottom method, but you are right that it creates confusion. I still find it semi-useful in a ways because I would use them differently given the context/operation that I'm doing. E.g. for draw calls, I rather use left/right, as they imply some computed value whereas x, y I would mostly use for more "math" like operations.
| } | ||
|
|
||
| // @TODO check if we still need this | ||
| if (inverted) { |
There was a problem hiding this comment.
inverted aka top-down flamegraph
|
|
||
| // Check if our rect overlaps with the current viewport and skip it | ||
| if ( | ||
| isOutsideView(frameInConfigSpace, configViewSpace, !!this.flamegraph.inverted) |
There was a problem hiding this comment.
Maybe this is because I'm not sure what inverted means, but if inverted is already used to initialize the Rect, it shouldn't be needed for this isOutsideView check right?
There was a problem hiding this comment.
Yes, we dont initialize inverted with Rect right now because I dont want to tie it to the flamegraph. The problem is that currently we kind of fake invert rectangles... we remap their depth, whereas the real solution would be to change coordinate system. That could be a good task if you want to take a stab at it. It would allow us to simplify some of the code and make it more straightforward
TextRenderer class for rendering text on the canvas.
Since WebGL doesnt have very nice support for text rendering and we dont want to mess around with glyphs, we use an overlay canvas that draws text onto the rectangles.
CleanShot.2022-01-18.at.09.18.39.mp4