Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui): Convert globalSelectionLink to RTL #31007

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Jan 8, 2022

No description provided.

@scttcper scttcper requested a review from a team January 8, 2022 00:15
@priscilawebdev
Copy link
Member

do you think we can update the file extension to be .tsx?

only the getContext function would need some updates:

  function getContext(query: {project: string[]; environment: string}) {
    return TestStubs.routerContext([
      {
        router: TestStubs.router({
          location: {query},
        }),
      },
    ]);
  }

@scttcper scttcper enabled auto-merge (squash) January 14, 2022 18:16
@scttcper scttcper merged commit 0ae7d16 into master Jan 14, 2022
@scttcper scttcper deleted the scttcper/rtl/globalSelection branch January 14, 2022 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants