ref(analytics): Analytics Refactor + Types #30555
Conversation
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
| @@ -1,3 +1,4 @@ | |||
| from sentry.utils.imports import import_submodules | |||
|
|
|||
| import_submodules(globals(), __name__, __path__) | |||
| path = __path__ # type: ignore | |||
There was a problem hiding this comment.
Without the ignore, mypy says:
error: Name '__path__' is not defined
|
|
||
| if isinstance(value, dict): | ||
| # Ensure we don't mutate the original. We do not need to deepcopy; | ||
| # if it recurses into another Map it will once again copy itself. |
There was a problem hiding this comment.
You're aware that if the dictionary has a list or some other complex object in it, that object will not be copied? The comment is a little unclear here, I can't tell if you're saying copy will recurse (which it won't) or extract recurses.
There was a problem hiding this comment.
I just copied this class to a file so I don't know what the intention was for this comment. I'll leave a note in the code here.
mgaeta
force-pushed
the
ref/events-types
branch
from
0af18ac
to
436a10e
Compare
mgaeta
force-pushed
the
ref/events-types
branch
from
436a10e
to
ee91c62
Compare
This PR refreshes the analytics modules with a few things:
If there's too much going on here I think I can pull types into a separate PR.