Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue self-hosted rename in build-related files #30483

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Continue self-hosted rename in build-related files #30483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ statusProvider:
name: github
config:
contexts:
- 'onpremise-builder (sentryio)'
- 'self-hosted-builder (sentryio)'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/getsentry/craft#status-provider

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        const contextResult = this.getStatusForContext(
          contextString,
          revisionStatus,
          revisionCheckSuites,
          revisionChecks
        );

https://github.com/getsentry/craft/blob/1e352b9e6fd486abc16f7f249b243929b26dd679/src/status_providers/github.ts#L69-L74

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. https://github.com/getsentry/sentry/runs/4448300537

Where is it on this PR? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this where I have to do /gcbrun? 🧐

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright yeah this is where I start to fall off in terms of permissions/visibility ... I gather that there is some manually configured job name in GCR ... 🤨

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where I start to fall off in terms of permissions/visibility

OR DO I!?!?!?!?!?!

Screen Shot 2021-12-07 at 5 25 27 PM

💃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, Google may very well show me a "Save" button but throw an error if I click it. 🙄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I can edit. 😁

Screen Shot 2021-12-07 at 5 29 50 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Sooooooooo ... when this PR lands I intend to edit the two triggers in GCB. I'll keep an eye on this during the 21.12.0 release ... kicked out getsentry/self-hosted#1193 for that.

artifactProvider:
name: gcs
config:
Expand Down
10 changes: 5 additions & 5 deletions docker/cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,23 @@ steps:
]
timeout: 300s
- name: 'gcr.io/$PROJECT_ID/docker-compose'
id: get-onpremise-repo
id: get-self-hosted-repo
waitFor: ['-']
entrypoint: 'bash'
args:
- '-e'
- '-c'
- |
mkdir onpremise && cd onpremise
curl -L "https://github.com/getsentry/onpremise/archive/master.tar.gz" | tar xzf - --strip-components=1
mkdir self-hosted && cd self-hosted
curl -L "https://github.com/getsentry/self-hosted/archive/master.tar.gz" | tar xzf - --strip-components=1
echo '{"version": "3.4", "networks":{"default":{"external":{"name":"cloudbuild"}}}}' > docker-compose.override.yml
- name: 'gcr.io/$PROJECT_ID/docker-compose'
id: e2e-test
waitFor:
- runtime-image
- get-onpremise-repo
- get-self-hosted-repo
entrypoint: 'bash'
dir: onpremise
dir: self-hosted
args:
- '-e'
- '-c'
Expand Down