Skip to content

fix(sentry_apps): correct 'occured' -> 'occurred' in SentryAppError comments and message #113058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SAY-5 wants to merge 1 commit into from
Closed

fix(sentry_apps): correct 'occured' -> 'occurred' in SentryAppError comments and message #113058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/sentry_apps/utils/errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def __repr__(self) -> str:
return f"{type(self).__name__}: message={self.message} status_code={self.status_code} error_type={self.error_type}"


# Represents a user/client error that occured during a Sentry App process
# Represents a user/client error that occurred during a Sentry App process
class SentryAppError(SentryAppBaseError):
error_type = SentryAppErrorType.CLIENT
status_code = 400
Expand All @@ -71,7 +71,7 @@ class SentryAppSentryError(SentryAppBaseError):
def to_public_dict(self) -> SentryAppPublicErrorBody:
error_id = sentry_sdk.capture_exception(self, level="info")
return {
"detail": f"An issue occured during the integration platform process. Sentry error ID: {error_id}"
"detail": f"An issue occurred during the integration platform process. Sentry error ID: {error_id}"
Copy link
Copy Markdown
Contributor

@sentry sentry Bot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The PR corrects a typo in an error message, but the corresponding unit tests still assert on the old, misspelled string, which will cause test failures.
Severity: LOW

Suggested Fix

Update the expected error message string in the test assertions to match the corrected spelling. Change "occured" to "occurred" in tests/sentry/sentry_apps/api/endpoints/test_sentry_app_installation_external_issues.py on line 126 and in tests/sentry/sentry_apps/api/bases/test_sentryapps.py on line 267.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/sentry_apps/utils/errors.py#L74

Potential issue: The pull request corrects a typo in an error message string from
"occured" to "occurred" in `src/sentry/sentry_apps/utils/errors.py`. However, the
corresponding unit tests that assert on this specific error message have not been
updated. These tests, located in `test_sentry_app_installation_external_issues.py` and
`test_sentryapps.py`, still expect the old string containing the typo. As a result, the
string comparison in the test assertions will fail, causing the test suite to fail and
blocking the continuous integration pipeline.

Did we get this right? 👍 / 👎 to inform future reviews.

}

def response_from_exception(self) -> Response:
Expand Down
Loading